Fix UriRetriever test #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakre
pushed a commit
to hakre/json-schema
that referenced
this pull request
Mar 26, 2015
Fix UriRetriever test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from extending and fixing the test, the return condition in the entry point of the Undefined constraint changed bc9438a. That's probably the main point of this pull request.
In its more general former state the return condition has been hiding the fact that the test wasnt working and the validation of the retrieved schema was silently skipped.
Couldn't identify any code that explicitly depends on the more general condition, such code would run into an exception.