Skip to content

Conversation

@jsimonetti
Copy link
Owner

No description provided.

@jsimonetti jsimonetti merged commit ba8be0e into master Sep 25, 2023
@jsimonetti jsimonetti deleted the gotest branch September 25, 2023 15:16
@SuperQ
Copy link
Contributor

SuperQ commented Nov 27, 2023

I would actually recommend keeping the previous style. The Go modules go directive specifies a minimum version need. So in order to test properly from the current version (1.18) the matrix would need to be 1.18.x -> 1.21.x inclusive.

@jsimonetti
Copy link
Owner Author

Hmm, you have a point. It's a bit more work maintaining, but at least the tests are explicit and test the correct things.

jsimonetti added a commit that referenced this pull request Nov 27, 2023
Using an explicit matrix, makes sure the required version of the module
can be tested.

Signed-off-by: Jeroen Simonetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants