Skip to content

Use req.socket instead of req.connection #8 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
briceruzand wants to merge 1 commit into from
Closed

Use req.socket instead of req.connection #8 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function forwarded (req) {

// simple header parsing
var proxyAddrs = parse(req.headers['x-forwarded-for'] || '')
var socketAddr = req.connection.remoteAddress
var socketAddr = req.socket.remoteAddress
Copy link

@mcollina mcollina Feb 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var socketAddr = req.socket.remoteAddress
var socketAddr = req.socket ? req.socket.remoteAddress : req.connection.remoteAddress

A test should be added to cover this case.

var addrs = [socketAddr].concat(proxyAddrs)

// return all addresses
Expand Down
2 changes: 1 addition & 1 deletion test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('forwarded(req)', function () {

function createReq (socketAddr, headers) {
return {
connection: {
socket: {
remoteAddress: socketAddr
},
headers: headers || {}
Expand Down