Add extra css #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexnm
reviewed
Nov 16, 2022
| *, | ||
| *::before, | ||
| *::after { | ||
| box-sizing: border-box; |
Contributor
There was a problem hiding this comment.
we should add this to the starter as well, not just in the final solution. it's actually a great point to discuss with beginners, I remember when I started with html/css this was one of the things that always confused me
Contributor
Contributor
There was a problem hiding this comment.
UPDATE: starterImprovement branch is now merged so maybe we can create a new branch for the above comment
src/style.css
Outdated
| this example is useful for a React app that would render in a div with id root | ||
| */ | ||
| #root { | ||
| isolation: isolate; |
Contributor
There was a problem hiding this comment.
I would skip some of these in the starter, to make sure we don't overwhelm people with things they don't know about/don't need for this intro.
We can use it as a reset for the react-starter though, even in a separate file or something
pogadev18
reviewed
Nov 17, 2022
src/index.html
Outdated
| </section> | ||
| <section> | ||
| <h2 class="u-screen-reader-text">Repositories</h2> | ||
| <!-- remove content from ul, so we can use :empty to display the loading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:emptypseudo element to display the loading messagedid not format the files so we can more easily compare the changes, but i have the formatted versions - I would suggest that we use the default prettier settings