Add percentEncodeAfterEncoding for all encodings #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
changed the title
Member
|
Amazing, thank you! This looks perfect. I notice it is marked as draft; should I delay merging it for a bit? |
Member
|
Running integration tests with jsdom reveals that we don't pass the tests for ShiftJIS. I'll work to try to create a minimal example and pinpoint the issue... |
Contributor
Author
@domenic the base PR is marked as draft )
Hm. Thanks! |
Member
|
Shift_JIS issue was a test bug: web-platform-tests/wpt#57476. I'll merge this all into jsdom now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #308, but implements all encodings, including
iso-2022-jp, and uses a released version of@exodus/bytes.