TUninstallLogHeader-cleanup #576
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors wizard-related configuration from TUninstallLogHeader to TMessagesLangOptions, improving the architecture by separating "sticky" installer state (accumulated across installs) from "non-sticky" UI preferences (controlled by the latest installer).
Key Changes:
- Moved wizard-related flags (lfWizardModern, lfWizardDarkStyleDark, etc.) from TUninstallLogFlags to TMessagesLangOptionsFlags
- Moved WizardSizePercentX/Y fields from TUninstallLogHeader to TMessagesLangOptions
- Simplified the Save method in TUninstallLog by removing complex sticky/non-sticky flag management
- Incremented version numbers (HighestSupportedHeaderVersion: 1048→1054, file version: 51.1053→51.1054, MessagesLangOptionsID: '!mlo!002'→'!mlo!003')
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Projects/Src/Shared.Struct.pas | Defines TMessagesLangOptionsFlag enum and adds WizardSizePercent fields to TMessagesLangOptions; updates MessagesLangOptionsID version |
| Projects/Src/Setup.UninstallLog.pas | Replaces wizard flags with ufDoNotUse placeholders, deprecates WizardSizePercent fields in header, simplifies Save/Load methods, updates version to 1054 |
| Projects/Src/Setup.Uninstall.pas | Updates code to read wizard flags from MessagesLangOptions instead of UninstLog; moves SetupHeader initialization from RunSecondPhase to RunUninstaller |
| Projects/Src/Setup.Install.pas | Adds GetMsgDataExtraFlags function to generate wizard flags; removes wizard flag assignments from UninstLog; updates WriteMsgData calls to pass wizard configuration |
| Projects/Src/Setup.Install.HelperFunc.pas | Updates WriteMsgData signature to accept WizardSizePercent parameters and extra flags; populates TMessagesLangOptions with wizard configuration |
| Projects/Res/Setup.version.rc | Updates file version from 51.1053.0.0 to 51.1054.0.0 |
| Projects/Res/Setup.version.res | Binary resource file reflecting version update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gesLangOptions.