Branch: FormBackgroundStyleHook #570
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Projects/Src/Setup.MainFunc.pas
…nd/or a back color.
Todo: -Hide SelectLanguageForm bevel and WizardForm bottom bevel? Optionally? -Make NewCheckListBox use the color when WantTabs is True. -Support it in Uninstall? -Doc.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for custom wizard background colors in Inno Setup, extending the existing wizard styling capabilities. The implementation introduces new WizardBackColor and WizardBackColorDynamicDark directives that allow setup authors to customize the background color of wizard forms when using VCL styles.
Key Changes
- Added new
WizardBackColorandWizardBackColorDynamicDarkfields to the setup header and associated setup directives - Implemented
TFormBackgroundStyleHookto apply custom background colors to forms when VCL styles are enabled - Updated wizard image back color logic to set
clNonewhen image files are explicitly cleared
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Projects/Src/Shared.Struct.pas | Added WizardBackColor and WizardBackColorDynamicDark fields to TSetupHeader, updated SetupID version |
| Projects/Src/Shared.SetupSectionDirectives.pas | Added ssWizardBackColor and ssWizardBackColorDynamicDark directives |
| Projects/Src/Setup.WizardForm.pas | Updated form initialization to support custom backgrounds via ParentBackground property and CustomWizardBackground flag |
| Projects/Src/Setup.TaskDialogForm.pas | Modified to conditionally apply custom background based on CustomWizardBackground flag |
| Projects/Src/Setup.SelectLanguageForm.pas | Modified to conditionally set ParentBackground based on CustomWizardBackground flag |
| Projects/Src/Setup.MainFunc.pas | Registered FormBackgroundStyleHook, initialized CustomWizardBackground global, handled dynamic dark color switching |
| Projects/Src/Compiler.SetupCompiler.pas | Added parsing for new directives, updated wizard image back color logic to handle explicit empty values |
| Projects/SetupCustomStyle.dproj | Added reference to FormBackgroundStyleHook.pas |
| Projects/SetupCustomStyle.dpr | Added FormBackgroundStyleHook unit to uses clause |
| Projects/Setup.dproj | Added reference to FormBackgroundStyleHook.pas |
| Projects/Setup.dpr | Added FormBackgroundStyleHook unit to uses clause |
| Components/NewStaticText.pas | Updated TNewStaticTextStyleHook to use control's Color property instead of style color |
| Components/NewNotebook.pas | Published ParentBackground property for TNewNotebook and TNewNotebookPage |
| Components/FormBackgroundStyleHook.pas | New file implementing style hook for custom form backgrounds |
| Components/BitmapImage.pas | Added safety checks for empty bitmaps to prevent operations on uninitialized graphics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # Projects/Src/Setup.TaskDialogForm.pas
…his was actually why I added the option).
Todo: -Hide SelectLanguageForm bevel. -Make NewCheckListBox use the color when WantTabs is True. -Support it in Uninstall? -Doc. -Translate clWindow/clBtnFace if only backcolor is used.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # Projects/Src/Setup.MainFunc.pas
…WantTabs mode (which makes it looks like an ordinary list of checkboxes/radiobuttons).
# Conflicts: # Projects/Src/Setup.MainFunc.pas # whatsnew.htm
# Conflicts: # whatsnew.htm
# Conflicts: # ISHelp/isetup.xml # Projects/Src/Compiler.SetupCompiler.pas # Projects/Src/Setup.MainFunc.pas # whatsnew.htm
…ing unins000.dat file. Oops.
# Conflicts: # Projects/Src/Setup.MainFunc.pas # whatsnew.htm
# Conflicts: # whatsnew.htm
Also fixes the file version number not being upped so far.
…fore branch is merged.
# Conflicts: # Projects/Src/Setup.UninstallLog.pas
# Conflicts: # whatsnew.htm
Commit doesn't show anything for Setup.Uninstall.pas because the block was already moved there (but also extended, thus the conflict). # Conflicts: # Projects/Src/Setup.MainFunc.pas # Projects/Src/Setup.Uninstall.pas
Updated whatsnew during merge. # Conflicts: # whatsnew.htm
… the color). Todo: doc & make it easier to get CustomWizardBackground activated without it being visible.
…h but doing it on branch anyway to avoid conflict.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 33 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
whatsnew.htm:1
- Corrected release date from '2025-11-20' to '2025-11-19'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martijnlaan
force-pushed
the
FormBackgroundStyleHook
branch
from
009abd2 to
358a929
Compare
martijnlaan
force-pushed
the
FormBackgroundStyleHook
branch
from
358a929 to
487e955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.