Body wrapper customization. Fix #280 #281
Conversation
jrblevin
left a comment
jrblevin
left a comment
There was a problem hiding this comment.
Thanks for this PR! I have a few small comments. Two lines seem to break the Markdown in the README, so those are more important.
If you are also able to add some simple tests and update CHANGES.md, then I'll be able to get this merged more quickly.
| ;; | ||
| ;; * `markdown-xhtml-body-preamble' - additional content to include in the | ||
| ;; XHTML <body> block, before the output. This is useful if you'd like to | ||
| ;; wrap the Markdown output around extra elements (default: `""`')." |
| ;; | ||
| ;; * `markdown-xhtml-body-epilogue' - additional content to include in the | ||
| ;; XHTML <body> block, after the output. This is useful if you'd like to | ||
| ;; wrap the Markdown output around extra elements (default: `""`'). |
There was a problem hiding this comment.
Stray single quote (`) here also.
| ;; Maintainer: Jason R. Blevins <[email protected]> | ||
| ;; Created: May 24, 2007 | ||
| ;; Version: 2.4-dev | ||
| ;; Package-Version: 20171031.1725 |
There was a problem hiding this comment.
Please remove this Package-Version header.
| "<body>\n\n") | ||
| (when (> (length markdown-xhtml-body-preamble) 0) | ||
| (insert markdown-xhtml-body-preamble)) | ||
| (insert "\n") |
There was a problem hiding this comment.
It might be better to put this newline inside the when block, so that existing output for those who haven't customized this variable will be exactly the same.
| (insert markdown-xhtml-body-preamble)) | ||
| (insert "\n") | ||
| (goto-char (point-max)) | ||
| (insert "\n") |
There was a problem hiding this comment.
Same for this newline (see above).
|
Here is a sketch of a test that I started working on. I didn't test the test yet though, but hopefully if it doesn't work as is it can be a good starting point. (ert-deftest test-markdown-export/body-preamble ()
"Test `markdown-xhtml-body-preamble'."
(markdown-test-temp-file "export-test.md"
(let* ((str "<!-- body preamble test -->")
(markdown-xhtml-body-preamble str)
(ofile (markdown-export))
(obuffer (get-file-buffer ofile)))
(with-current-buffer obuffer
(goto-char (point-min))
(should (search-forward str)))
(kill-buffer obuffer)
(delete-file ofile)))) |
|
Ah I've completely forgotten about this PR. Thanks for fixing. |
2 participants
This allows the addition of a body preamble and epilogue to further customize the generated HTML.