Skip to content

Conversation

@emasab
Copy link
Contributor

@emasab emasab commented Dec 13, 2012

Hi malsup, here is the pull request that you asked me. Sorry for the delay, but I was kind of busy.

@kevindb
Copy link
Member

kevindb commented Mar 6, 2017

Is this PR still necessary?

Possibly related to #358 custom iframeTarget doesn't attach load listener
Possibly resolved by d0e782f

@kevindb kevindb added the bug label Mar 6, 2017
@emasab
Copy link
Contributor Author

emasab commented Mar 7, 2017

for the ownerDocument thing, The problem was that
http://stackoverflow.com/questions/2284356/cant-appendchild-to-a-node-created-from-another-frame
maybe it's present in IE10 too, because here states
https://msdn.microsoft.com/en-us/library/gg592979(v=vs.85).aspx

The node is owned by a different document and cannot be used. Starting with Internet Explorer 10, the error-code string WrongDocumentError is returned instead.

It usually happens when using jQuery from the opener window and the form is in the opened window.

The move of
if (io.attachEvent)
is necessary for the custom iframeTarget

@kevindb
Copy link
Member

kevindb commented Mar 7, 2017

Whew! This gets messy with a four year old PR. It looks like d0e782f (8 months after your PR) took care of moving if (io.attachEvent).

Would you please update your PR (or create a new one, if that's easier) from current master for your form.ownerDocument and $form.closest('body') changes?

@emasab
Copy link
Contributor Author

emasab commented Mar 7, 2017

here is the new PR

#518

@kevindb kevindb closed this in 60d99a9 Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants