chore: upgrade storybook #1308
Merged
chore: upgrade storybook #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge of latest head changes
merging latest from base project
jquense
reviewed
May 7, 2019
.storybook/webpack.config.js
Outdated
| config.module.rules.push(rules.fonts()) | ||
| config.module.rules.push(rules.images()) | ||
| config.module.rules.push(rules.css()) | ||
| config.module.rules.push(rules.less({ browsers })) |
Owner
There was a problem hiding this comment.
this will now use the default rules, which i don't think we want...
Collaborator
Author
There was a problem hiding this comment.
I've pushed an update to completely override the 'rules'. They did have a rule (from the @storybook/react package) already for the js compile, as well as some bits for handling media, but this new config more closely mirrors what you were doing before.
Owner
|
thanks! |
cutterbl
added a commit
to cutterbl/react-big-calendar
that referenced
this pull request
May 7, 2019
chore: upgrade storybook (jquense#1308)
|
🎉 This PR is included in version 0.38.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Storybook dependencies and configuration/addon registration.