Perf: copying dir contents in parallel #1026
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
approved these changes
Nov 10, 2023
Collaborator
RyanZim
left a comment
RyanZim
left a comment
There was a problem hiding this comment.
Change looks good to me; but would like a second pair of eyes here to make sure I'm not missing something.
Collaborator
|
@manidlou bump |
Collaborator
|
Published in v11.2.0! |
Contributor
Author
|
@RyanZim ❤️ Too bad I can't port this change to Node.js' |
Collaborator
You'd have to implement a concurrency limit yourself, I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR uses a technique similar to #885 to speed up the recursive copy operation.
As
fs-extrais built on top ofgraceful-fs, this change won't causeEMFILE: too many open filesasgraceful-fswill exponentially backoff and retry.