Skip to content

Refactor copy API in async/await #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanZim merged 15 commits into from
Oct 24, 2023
+202 −249
Merged

Refactor copy API in async/await #1021

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
56428e3
Refactor `copy` API in async/await
SukkaW Oct 19, 2023
f04093f
Update test to import `copy` from main exports
SukkaW Oct 19, 2023
47db735
Use promisified fs API from `lib/fs`
SukkaW Oct 20, 2023
e125aa2
Update test to import `ncp` from re-exports
SukkaW Oct 20, 2023
d9f8ef9
Use promisfied fs API from `lib/fs`
SukkaW Oct 20, 2023
bc8ee0b
Apply code review suggestions from @RyanZim
SukkaW Oct 21, 2023
cf3aed7
Refactor copy recursive logic
SukkaW Oct 21, 2023
a3e2c21
Universalify stat utility
SukkaW Oct 21, 2023
dbfdb31
Universalify the `gracefulFsStub` inside the unit test
SukkaW Oct 21, 2023
b27cdfa
Inline preserve timestamp function
SukkaW Oct 21, 2023
20ac969
Make `standard` happy
SukkaW Oct 21, 2023
eebb61d
Inline `setDestMode`
SukkaW Oct 21, 2023
ce7cf64
Remove duplicated `opts` handling
SukkaW Oct 21, 2023
1ce5d34
Apply code review suggestions from @RyanZim
SukkaW Oct 24, 2023
c2d1871
Make `standard` happy
SukkaW Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/copy/__tests__/copy-broken-symlink.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const os = require('os')
const fse = require('../..')
const path = require('path')
const assert = require('assert')
const copy = require('../copy')
const { copy } = require('../')
Copy link
Contributor Author

@SukkaW SukkaW Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to change the import here. lib/copy/copy.js now exports the promise-only API (instead of the callback-only API), while lib/copy/index.js now exports the unified API.


/* global afterEach, beforeEach, describe, it */

Expand Down
2 changes: 1 addition & 1 deletion lib/copy/__tests__/copy-preserve-timestamp.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const fs = require('../../')
const os = require('os')
const path = require('path')
const copy = require('../copy')
const { copy } = require('../')
const utimesSync = require('../../util/utimes').utimesMillisSync
const assert = require('assert')

Expand Down
2 changes: 1 addition & 1 deletion lib/copy/__tests__/ncp/broken-symlink.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const fs = require('fs')
const os = require('os')
const fse = require('../../..')
const ncp = require('../../copy')
const { copy: ncp } = require('../../')
const path = require('path')
const assert = require('assert')

Expand Down
2 changes: 1 addition & 1 deletion lib/copy/__tests__/ncp/ncp-error-perm.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
const fs = require('fs')
const os = require('os')
const fse = require('../../..')
const ncp = require('../../copy')
const { copy: ncp } = require('../../')
const path = require('path')
const assert = require('assert')

Expand Down
2 changes: 1 addition & 1 deletion lib/copy/__tests__/ncp/ncp.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const fs = require('fs')
const ncp = require('../../copy')
const { copy: ncp } = require('../../')
const path = require('path')
const rimraf = require('rimraf')
const assert = require('assert')
Expand Down
2 changes: 1 addition & 1 deletion lib/copy/__tests__/ncp/symlink.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const fs = require('fs')
const os = require('os')
const fse = require('../../..')
const ncp = require('../../copy')
const { copy: ncp } = require('../../')
const path = require('path')
const assert = require('assert')

Expand Down
Loading