Skip to content

Conversation

@rsln-s
Copy link
Contributor

@rsln-s rsln-s commented Sep 1, 2023

No description provided.

@rsln-s rsln-s requested a review from ZichangHe September 1, 2023 14:18
@rsln-s
Copy link
Contributor Author

rsln-s commented Sep 1, 2023

Should be good to merge after @ZichangHe reviews as this is simply a sync of commits that were missed during the open-sourcing process.

@ZichangHe
Copy link
Contributor

All test passed in my local repo.

I found two errors (easy to fix) by running example notebooks:

  1. parameter_utils.get_LABS_wrt_best_overlap function is missing
  2. nlopt is not installed automatically

Anything else specific to look at?

@rsln-s
Copy link
Contributor Author

rsln-s commented Sep 1, 2023

Thanks for checking! Would you mind fixing? For (1), just change the function call to the correct one. For (2), add a comment in notebook to install nlopt as an optional dependency (pip install nlopt)

@ZichangHe
Copy link
Contributor

Done. Should be good to merge.

Copy link
Contributor

@ZichangHe ZichangHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We now have only one get_qaoa_objective now (get_qaoa_xy_objective is gone).

@rsln-s rsln-s merged commit ca50e3f into main Sep 1, 2023
@rsln-s rsln-s deleted the fef96a4_ZichangHe branch September 1, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants