Skip to content

Conversation

@remeh
Copy link

@remeh remeh commented Jun 28, 2013

I'm using your notification lib (I've chosen it for the ability to create either element notifications or global notifications) but I need to embed some HTML tags for the content.
I've slightly modified it to do so and this is the content of this pull-request.
I don't think this modification should interest you but if it does, here it is ;)

@jpillora
Copy link
Owner

Hi Remy, thanks for the PR, will check it later on today :)

On Saturday, June 29, 2013, Rémy Mathieu wrote:

I'm using your notification lib (I've chosen it for the ability to create
either element notifications or global notifications) but I need to embed
some HTML tags for the content.
I've slightly modified it to do so and this is the content of this
pull-request.
I don't think this modification should interest you but if it does, here

it is ;)

You can merge this Pull Request by running

git pull https://github.com/remeh/notifyjs master

Or view, comment on, or merge it at:

#2
Commit Summary

  • Let embed html in the content of the notification

File Changes

Patch Links:

@jpillora
Copy link
Owner

Hey Remy,
I guess you wouldn't have read it because you're using the default style, though go to http://notifyjs.com then down to the Custom Styling Guide section on html. In my "bootstrap" style, I've purposefully set data-notify-text, though you can change that to data-notify-html to achieve what you're after. It's important to make this explicit because allowing arbitrary HTML in user prompts can be very dangerous from a security stand point.

Use the custom build tool, load the "bootstrap" style and in the html property, change the data-notify-text to data-notify-html and click build

@jpillora jpillora closed this Jun 29, 2013
@remeh
Copy link
Author

remeh commented Jun 29, 2013

Hey, I've created a theme but I didn't see this little detail !
That's perfect, sorry for the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants