Style from `CustomTabProvider` is overwritten

[Nutomic]

I am trying to have a single tab with a different text color. For this, I implement CustomTabProvider and call TextView.setTextColor().

However, this change is overwritten by updateTabStyles().

I suggest to change the code so, that the tab style is only applied by the library if CustomTabProvider is not implemented. (I will probably make a pull request for this myself).

[ouchadam]

👍
for now I'm using a different id to tab_title so that updateTabStyles() skips

[jpardogo]

Do you think we really need to update the library for that? Don´t you think it is fair enough just not using the id R.id.psts_tab_title in your custom tabs.

NOTE: I have just prefix the xml files and id´s of the library for v1.0.9

[jpardogo]

I leave it like that. If we change it someone will create another issue asking why the text and the style are not apply to the TextView title of the custom tabs.
If you don't want the library manage your TextView title for the tab, use a different id than R.id.psts_tab_title in your tab layout.

[ataulm]

Just had a chat with @ouchadam. The problem he was facing was that he uses a custom tab layout so that a custom font can be used.

If using a different ID as you suggest, it won't change the alpha of the text of tabs when one is selected/not-selected, because the class cannot find the text view. But if you do use the same ID, then many of the textview attributes are updated.

So the problem comes back to the fact that there's no selected/not selected state for the tab (#70) else this differentiation between selected/not-selected tabs can be done by us.

[ataulm]

oh seems that PR I submitted was covered by #51. If you supply a custom tab layout that doesn't use the R.id.psts_tab_title ID, your TextView should be untouched.

The problem remains here I think:

private void updateTabStyles() {
    for (int i = 0; i < tabCount; i++) {
        View v = tabsContainer.getChildAt(i);
        v.setBackgroundResource(tabBackgroundResId);
        v.setPadding(tabPadding, v.getPaddingTop(), tabPadding, v.getPaddingBottom());
        TextView tab_title = (TextView) v.findViewById(R.id.psts_tab_title);

        if (tab_title != null) {
        ...

or more specifically:

View v = tabsContainer.getChildAt(i);
v.setBackgroundResource(tabBackgroundResId);
v.setPadding(tabPadding, v.getPaddingTop(), tabPadding, v.getPaddingBottom());

where it updates your tab regardless of ID. If a custom tab was supplied, the library should do no styling on the tab itself.

[ataulm]

#51 seems to use updateSelection(int position) (which sets the selected state) in only one place, but there are other places where selected(int position) and unselected(int position) are used directly, meaning the selected state won't be set correctly (I think, haven't looked too long at it).

[ouchadam]

I like the idea of the CustomTabProvider being given all of the major callbacks for tab selection, style reseting etc

[Nutomic]

Sorry for the late reply.

I tried to use an ID different than tab_title. The problem with that is that no font style is applied at all. Imo it would be nice to have the default style applied, and then apply my own costumizations afterwards.

One possibility for this would be changing updateTabStyles() so that it's public and can be called from getCustomTabView(), or call it here if CustomTabProvider is not implemented.

I hope you undestand what I mean, otherwise I could just make a PR.

[camposbrunocampos]

Hello Guys, turns out that there is a better solution.
You could just create a selector resource inside res/colors/ and use it in your PagerSlidingStrip android:textColor attribute. I`ll print the code below.
The text will change its color like a selector button, simple like that. There is no need of changing the lib.

res/color/btn

<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android">
    <item android:state_pressed="true"
        android:color="#000000" /> <!-- pressed -->
    <item android:state_focused="true"
        android:color="@color/active_text" /> <!-- focused -->
    <item android:color="#FFFFFF" /> <!-- default -->
</selector>

and here is where I use this resource in andorid:textColor attribute

slideFragment.xml

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical">
    <com.astuetz.PagerSlidingTabStrip
        android:id="@+id/pager_title"
        android:layout_width="match_parent"
        style="@style/PagerTitleStrip"
        android:layout_gravity="top"
        android:textColor="@color/btn"
        android:textSize="13sp"
        android:paddingBottom="@dimen/padding_logo"
        android:paddingTop="@dimen/padding_logo"
        app:pstsIndicatorColor="@color/border_title_strip"
        android:layout_height="@dimen/height_pager_title_strip"/>
    <android.support.v4.view.ViewPager
        android:id="@+id/pager"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:layout_weight="1">

    </android.support.v4.view.ViewPager>
</LinearLayout>

[Nutomic]

@camposbrunocampos If I understand this correct, it changes the color for all tabs. I only want to change a single tab's color (so there are different colors).

[camposbrunocampos]

@Nutomic Yes, you are right, only use this solution if you want to change the textColor for all tabs.