Open
Conversation
Owner
Some of the modified methods have citations in the comments prior to them, for example: I think it'd be wise to update these comments to include where the algorithm modifications were ported from. |
joshuaferrara
requested changes
May 25, 2020
Owner
joshuaferrara
left a comment
There was a problem hiding this comment.
Please include citations alongside the methods that were modified to indicate where the changes were ported from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some inaccuracies in time conversions and angle calculations that leaded in loosing several seconds on AOS and LOS times for ground station. Some of these changes breaks backward compatibility.
As a reference I used gPredict, pyorbital and sgp4