Skip to content

Comments

More accurate look angles#9

Open
mpielikis wants to merge 2 commits intojoshuaferrara:masterfrom
mpielikis:more-accurate-look-angles
Open

More accurate look angles#9
mpielikis wants to merge 2 commits intojoshuaferrara:masterfrom
mpielikis:more-accurate-look-angles

Conversation

@mpielikis
Copy link

There were some inaccuracies in time conversions and angle calculations that leaded in loosing several seconds on AOS and LOS times for ground station. Some of these changes breaks backward compatibility.

As a reference I used gPredict, pyorbital and sgp4

@joshuaferrara
Copy link
Owner

As a reference I used gPredict, pyorbital and sgp4

Some of the modified methods have citations in the comments prior to them, for example:

// Reference: The 1992 Astronomical Almanac, page K11.
func LLAToECI(obsCoords LatLong, alt, jday float64, gravConst GravConst) (eciObs Vector3) {

I think it'd be wise to update these comments to include where the algorithm modifications were ported from.

Copy link
Owner

@joshuaferrara joshuaferrara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include citations alongside the methods that were modified to indicate where the changes were ported from.

gs-jules
gs-jules approved these changes Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants