This repository was archived by the owner on Feb 27, 2019. It is now read-only.
Added two API methods which are required to get a tournament banner#34
Open
parfentjev wants to merge 2 commits intojoshuaduffy:masterfrom
parfentjev:master
Open
Added two API methods which are required to get a tournament banner#34parfentjev wants to merge 2 commits intojoshuaduffy:masterfrom parfentjev:master
parfentjev wants to merge 2 commits intojoshuaduffy:masterfrom
parfentjev:master
Conversation
…mage: get_schema_url and get_item_icon_path.
Owner
|
Thanks for this, will review. Will need some tests before I can merge but looks great! Thanks. |
Author
|
Any news on this? Maybe I can help? |
Owner
|
@ghostwolfling Yeah, I need some tests and docstrings before I can merge it in. For the tests have a look in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can read discussion about this on dev.dota2.com forum.