[Colors] Error color "red" seems off

[ianyepan]

Issue Description

As shown in the screenshot below, the color "red" for errors seems a bit off. I don't think it should be #ff0000 (as it is now), but rather something with less contrast that goes along with the rest of the onedark theme.

In terms of readability, I also think that #ff0000 is less readable against the blue-ish background.

[devinjameson]

Same error.

[joshdick]

There's nothing in onedark.vim that is explicitly styling errors to be #ff0000.

It looks like the popup in your screenshot is from neoclide/coc.nvim and not something like Neovim LSP diagnostics?

If so, I just merged #268 which adds highlight groups for coc.nvim and uses onedark.vim's native colors, but whether those colors are more readable than the defaults is frankly debatable.

[joshdick]

Closing due to inactivity, but feel free to keep the conversation going if needed!