Skip to content

Add breadcrumbs to uncaught exceptions #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcomorain merged 2 commits into from
Feb 1, 2017
Merged

Add breadcrumbs to uncaught exceptions #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea5cdc
Add breadcrumbs to uncaught exceptions
marcomorain Feb 1, 2017
edb70e9
1.5.3 release notes
marcomorain Feb 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ table below shows an example of what the data will look like in Sentry.

Version | Changes
--- | ---
**1.5.4** | Ensure that breadcrumbs are added to all exceptions. [#115](https://github.com/joshdholtz/Sentry-Android/issues/115).
**1.5.3** | Fix thread-safety bug when serializing breadcrumbs. [#110](https://github.com/joshdholtz/Sentry-Android/issues/110) (thanks to [fab1an](https://github.com/fab1an)).
**1.5.2** | Send stack-frames to Sentry in the correct order. [#95](https://github.com/joshdholtz/Sentry-Android/pull/95).<br/> Use the [versionName](https://developer.android.com/studio/publish/versioning.html#appversioning), rather than versionCode, as the default value for the release field of events (thanks to [FelixBondarenko](https://github.com/FelixBondarenko)).
**1.5.1** | Revert accidental API removal of `captureException(Throwable, SentryEventLevel)`.
Expand Down
2 changes: 1 addition & 1 deletion sentry-android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
apply plugin: 'com.android.library'


def SentryAndroidVersion = "1.5.3"
def SentryAndroidVersion = "1.5.4"

android {
compileSdkVersion 24
Expand Down
6 changes: 5 additions & 1 deletion sentry-android/src/main/java/com/joshdholtz/sentry/Sentry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ public class Sentry {
private static final String TAG = "Sentry";
private final static String sentryVersion = "7";
private static final int MAX_QUEUE_LENGTH = 50;
private static final int MAX_BREADCRUMBS = 10;

public static boolean debug = false;

Expand Down Expand Up @@ -517,6 +516,7 @@ public void uncaughtException(Thread thread, Throwable e) {
// Here you should have a more robust, permanent record of problems
SentryEventBuilder builder = new SentryEventBuilder(e, SentryEventLevel.FATAL);
builder.setRelease(sentry.appInfo.versionName);
builder.event.put("breadcrumbs", sentry.breadcrumbs.current());

if (sentry.captureListener != null) {
builder = sentry.captureListener.beforeCapture(builder);
Expand Down Expand Up @@ -656,6 +656,10 @@ enum Type {

private static class Breadcrumbs {

// The max number of breadcrumbs that will be tracked at any one time.
private static final int MAX_BREADCRUMBS = 10;


// Access to this list must be thread-safe.
// See GitHub Issue #110
// This list is protected by the provided ReadWriteLock.
Expand Down