-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix failing CI #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix failing CI #2122
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f2c8110
Upgrade CI runner to Ubuntu 24.04
NicholasBHubbard 5c79d32
List Python-specific dependencies in requirements.txt files
NicholasBHubbard fd65140
Use Python venv to avoid test interaction with system Python deps
NicholasBHubbard 17a72d8
Fix Lintian warnings about obsolete lsb-base package
NicholasBHubbard 8e27610
Remove obsolete get_metadata.py script & remove dep on simplejson
NicholasBHubbard 70377dd
pip use --ignore-installed flag
NicholasBHubbard d1754cb
Call marker.evaluate() with default marker environment
NicholasBHubbard 3fd28b5
Remove python venv
NicholasBHubbard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Listing of fpm's Python package dependencies | ||
| packaging | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Listing of fpm test-suite's Python package dependencies | ||
| setuptools |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also requires pip which isn't installed by default on Ubuntu (for example) when installing python3.
In the absence of a dependency (rpmbuild, tar, ar, python packaging, python wheel, python pip, etc), I would prefer fpm to detect this and provide the user with an actionable error message. At present (noted in #2118), it crashes with a stack trace which isn't very user friendly.
At some point, I may try to provide rpm/deb packages of fpm which express these dependencies.
(No change required, just documenting my thoughts on this specific item)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great notes, thanks @jordansissel !
Yes we definitely need to be aware of the missing pip requirement issues as @NicholasBHubbard and I continue with this development path.