Skip to content

Conversation

@NicholasBHubbard
Copy link
Contributor

This PR fixes up some of the end # def method_name comments in cpan.rb, package.rb, command.rb, gem.rb, and util.rb.

Now each of these files uses this comment convention for all of their methods. There were also a few of these comments with an incorrect function name that I fixed.

No non-comment code is changed in this PR.

@NicholasBHubbard NicholasBHubbard marked this pull request as ready for review October 28, 2025 18:05
@wbraswell
Copy link
Contributor

Howdy @jordansissel , long time no see! :-)
My old friend @NicholasBHubbard and I are back at it again - we have been carefully reviewing all of our old FPM pull requests including this one, and we have updated it to be in a state which we believe is ready for your approval.
This particular PR only fixes comments, but some of them are actually incorrect so personally I do suggest that we fix it.
Thanks for your time and we look forward to working with you on the other pull requests as well!

@jordansissel
Copy link
Owner

Looks good! Thanks for your effort tidying things up :)

@jordansissel jordansissel merged commit 4faa7ca into jordansissel:main Nov 4, 2025
0 of 4 checks passed
@wbraswell
Copy link
Contributor

@jordansissel
Wonderful, thank you sir! :-)

@NicholasBHubbard
Copy link
Contributor Author

@jordansissel Thanks!

@NicholasBHubbard NicholasBHubbard deleted the fixup-some-comments branch November 4, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants