Upgrades to cpan_spec.rb #1973
Merged
Upgrades to cpan_spec.rb #1973
+51
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks again for improving things! The test suite passes for me now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded
cpan_spec.rbso every method defined incpan.rbhas its own test.I upgraded the existing tests to explicitly set package versions to avoid the scenario that a new version of a CPAN distribution is released that breaks the test.
I also removed the stuff related to Travis CI as FPM now uses GitHub Actions.
On my machine these changes make the test suite take 5 seconds longer to run.
Let me know what you think!