Optimize CPU usage and energy impact of event monitoring #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only enable the `mouseMoved` event tap when the "Show on Hover" setting is enabled. - This prevents unnecessary event processing on every mouse movement when the feature is disabled, significantly reducing idle CPU usage and energy impact. - Added observers to dynamically start/stop the event tap when the setting is toggled. - fixes jordanbaird#479 Signed-off-by: Toni Förster <[email protected]>
- Throttle `mouseMoved` event processing to handle only every 5th event, significantly reducing CPU usage during high-frequency mouse movement. - Reorder checks in `isMouseInsideEmptyMenuBarSpace` to prioritize cheap geometric calculations over expensive Window Server calls. - Implement a short-lived cache (0.5s) for the menu bar window list in `isMouseInsideMenuBarItem` to minimize IPC overhead with the Window Server. Signed-off-by: Toni Förster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces optimizations to reduce the app's energy impact, regarding mouse event handling. This should fix issue #479 and issue #334
Conditional Event Monitoring:
mouseMovedevent tap is now only enabled when the "Show on Hover" setting is active.Event Throttling:
mouseMovedevents are now throttled to process only every 5th event.Optimized Hit-Testing: