[4.0] Remove article print and email #19393

brianteeman · 2018-01-17T11:06:33Z

The option to email a link to a friend and to print an article were outdated when joomla 1.0 was launched - there are far better ways to share content etc.

A quick unscientific test of live sites showed none that were using this

This pr removes the show print and email icons options and code

If I understand everything correctly nothing would need to be done to update upgrading sites databases as the stored param would simply be ignored

The option to email a link to a friend and to print an article were outdated when joomla 1.0 was launched - there are far better ways to share content etc. A quick unscientific test of live sites showed none that were using this This pr removes the show print and email icons options and code If I understand everything correctly nothing would need to be done to update upgrading sites databases as the stored param would simply be ignored

C-Lodder · 2018-01-17T11:27:08Z

+1

This would fix #19221 I suppose

rdeutz · 2018-01-17T11:57:29Z

email ok, but the print function is not bad

C-Lodder · 2018-01-17T11:59:58Z

@rdeutz - browsers have their own print functionality.

rdeutz · 2018-01-17T12:01:12Z

@C-Lodder I know but it works different

ghost · 2018-01-17T12:06:30Z

I have tested this item ✅ successfully on 3ff030f

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19393.}

brianteeman · 2018-01-17T12:21:30Z

browsers have their own print
print doesnt work on mobile
print.css will let you customise the print view in a much better way

rdeutz · 2018-01-17T12:25:30Z

That is something I have to explain to a client, at least I know that one of my clients will miss the button.

C-Lodder · 2018-01-17T12:27:10Z

@rdeutz But then again, you also have to explain to new clients that Joomla has a print feature and how to access it.

brianteeman · 2018-01-17T12:30:42Z

If this was a proposal to add a print button it would be rejected on the basis that its something that the majority of site owners would not want

rdeutz · 2018-01-17T12:31:08Z

I can disable the feature for new clients, but anyway do whatever you think is right. I have told my opinion

astridx · 2018-01-17T18:53:57Z

I have tested this item ✅ successfully on 97c99cb
I also made a new installation, as database data are changed. This was OK, too.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19393.}

brianteeman · 2018-01-19T01:22:44Z

thanks for testing

Quy · 2018-01-19T02:09:43Z

language/en-GB/en-GB.ini

 JGLOBAL_OTPMETHOD_NONE="Disable Two Factor Authentication"
 JGLOBAL_PASSWORD="Password"
 JGLOBAL_PASSWORD_RESET_REQUIRED="You are required to reset your password before proceeding."
 JGLOBAL_PRINT="Print"


I left this as it may be used elsewhere as I have done with many generic strings in the global language files

Quy · 2018-02-13T16:24:56Z

components/com_content/tmpl/article/default.php

-			</div>
-		<?php endif; ?>
+	<?php if ($canEdit) : ?>
+		<?php echo JLayoutHelper::render('joomla.content.icons', array('params' => $params, 'item' => $this->item, 'print' => false)); ?>


Remove 'print' => false?

oops ;)

Also need to check other views. Task for tomorrow

infograf768 · 2018-02-15T11:05:00Z

There is a big difference between printing via the browser and the Print article feature.
Printing via the browser will print the whole page.
Your Modules_article.pdf
Your Modules.pdf

I agree with @rdeutz
Let's keep the Print article.

ciar4n · 2018-02-15T11:11:28Z

@infograf768 Currently there is a big difference as there is no print specific CSS in the template. It is quite possible to make both of your examples look the same with the appropriate print specific styling.

C-Lodder · 2018-02-15T11:11:59Z

@infograf768 That's why we mave @media print { ... }

C-Lodder · 2018-02-15T11:16:13Z

If we want to just print an article or any content within the component area, then the following CSS can be used:

@media print {
    .container-header,
    .container-top-a,
    .container-top-b,
    .container-sidebar-left,
    .container-sidebar-right,
    .container-bottom-a,
    .container-bottom-b,
    .container-footer {
        display: none !important;
    }
}

infograf768 · 2018-02-15T11:36:15Z

This means that there is no choice on one hand between printing the whole page if the user wants to and a single article if the admin desires (after adding this css).

On the other hand, if a blog is displayed and there is no link to the specific article to force it to display alone, the result of such css is to print here 3 pages, 1st one blank, 2nd one with what ever gets into the pdf (it may be one or multiple articles) , 3rd one blank.

Here is the result printing as PDF

mbabker · 2018-02-15T14:54:26Z

Personal attacks removed. JM we know quite well that you would prefer nothing changes, especially if Brian is the one who opened the PR. You do not need to use personal attacks and insults every time. Same goes for everyone else who likes to commonly trash other people's work.

All that is being done is removing core support for creating these buttons. If you want them, create a layout override that generates a link to the current page with this query string: ?tmpl=component&print=1 and you have your "pretty" page that is suitable for print. Not that difficult if it's a capability you really want on your sites.

infograf768 · 2018-02-15T15:00:17Z

Apparently you did not like
use Joomla\CMS\MiltonFriedman\ChicagoBoys\PrintNoHelper;

I can understand that. Sense of humor depends on different cultures. 😸 And it has nothing to do with who created the PR, but to the fact that this functionnality is real useful.
You will remark that I said nothing about mail to a friend as I do think it is a good idea to get rid of that one.

mbabker · 2018-02-15T15:02:34Z

We aren't dropping the functionality in full though, that's the main point my comment was making. All we're removing is support for the JHtml helper that builds a button with the appropriate link (current page URI plus the query string I noted). If we were making it impossible to use the functionality I'd say something different, but really, this is so easily duplicated if you really need it I don't see why it needs to be a big concern.

dgrammatiko · 2018-02-15T15:05:59Z

but to the fact that this functionnality is real useful

Those facts are very subjective. The only objective thing here is that the CMS delivers a page to the browser. The browser is responsible for the printing not the CMS. Please let's not use practices from last century.

Also what @mbabker said above

brianteeman · 2018-02-15T15:09:04Z

That wasn't the offensive line as you well know - but nice try. Accept the PR and move into the 21st Century or stay in the dark ages. I am losing interest in Joomla very rapidly

infograf768 · 2018-04-04T10:03:10Z

The various proposals above (either the one from @C-Lodder or @mbabker )to print a specific article content did not work here except if the article is displayed alone in an otherwise empty page.
To solve the issue, the only way I found was to load a supplementary script (either in the article if one can or in all concerned overrides).

<script>
		function printDiv(divName){
			var printContents = document.getElementById(divName).innerHTML;
			var originalContents = document.body.innerHTML;
			document.body.innerHTML = printContents;
			window.print();
			document.body.innerHTML = originalContents;
		}
	</script>

and then add in the article

<div class="pull-right">
<button class="button btn btn-primary" onclick="printDiv('printarea')">Print only div below</button>
</div>
<div id='printarea'>

<p>The content of the article</p>

</div>

Which is impossible to do directly when using a WYSIWYG editor without a specific extension to enter js .
With this code I can print in staging , but it does not work in 4.0..... IN 4.0 I get the print dialog allright, but not the full div to print.

It's a real pity to be forced to use such "century-old practice" "in the 21st century".

One would say it is "normal" for a man using this kind of smartphone...

mbabker · 2018-04-04T11:45:45Z

If adding a tmpl=component query string is not working in the 4.0 branch then there is a bug to be addressed. It is not indicative that core is not supporting this at all anymore.

infograf768 · 2018-04-05T07:29:30Z

@mbabker
I have no idea how to use this code to print the content of the article and only the content of the article, whatever the way the article is displayed, i.e. alone, in blog or as featured.

mbabker · 2018-04-05T11:45:25Z

The "print URL" for the 3.8.6 release article is https://www.joomla.org/announcements/release-news/5725-joomla-3-8-6-release.html?tmpl=component

Similar to that, you need your link to have that tmpl=component query string in the request (the current helper generating the print button does exactly this). In your layout overrides, there are a couple of ways to accomplish this.

Probably the easiest:

$printUrl = clone JUri::current();
$printUrl->setVar('tmpl', 'component');

// When building your link, include 'echo $printUrl' to print the URL

brianteeman · 2018-07-13T21:08:20Z

@wilsonge can I have a yes/no/partial on this please and I will redo the pr

close
Accept removal of print and email
Accept removal of email only

infograf768 · 2018-07-14T09:29:02Z

Reminder to @wilsonge
None of the solutions proposed above did work to print a single article displayed in a blog or as featured when we have other articles displayed.

brianteeman · 2018-07-14T11:44:52Z

@infograf768 of course number 3 does - thats why it is there

rdeutz · 2018-08-18T10:34:32Z

for the test can you make a PR against this Repo https://github.com/joomla/test-integration files are in the 4.0-dev branch /legacy and remove the files from your PR here, thanks

brianteeman · 2018-08-18T14:15:29Z

@rdeutz So now we have a chicken and egg scenario

A new pr for the tests in the tests repo should only be merged if this PR is accepted
But this pr wont be accepted without working tests

wilsonge · 2018-08-19T09:51:48Z

I'm totally happy to remove print - this has been superseded by print stylesheets on pretty much all modern websites (and you'd use that to disable most the module positions in Joomla). I'm unsure as to whether we should remove the email functionality. Probably yes. But not 100%

brianteeman · 2018-08-19T09:55:51Z

Can someone make a decision 100% then so I only have to write/update this once please

dgrammatiko · 2018-08-19T10:03:04Z

this has been superseded by print stylesheets on pretty much all modern websites (and you'd use that to disable most the module positions in Joomla)

Just to add to what @wilsonge wrote above, there is a great css just for that: https://github.com/BafS/Gutenberg

brianteeman · 2018-09-25T18:27:07Z

Closed - obviously there is no interest in this

dgrammatiko · 2019-02-26T18:16:04Z

Thanks for reopening this!

brianteeman · 2019-02-26T18:39:42Z

I am going to resubmit it as this is over 12 months old and a pain to resolve the conflicts.

brianteeman · 2019-02-26T19:22:30Z

See #24025 for up to date PR

brianteeman added 2 commits January 17, 2018 11:02

remove unused layouts

3ff030f

joomla-cms-bot added Language Change This is for Translators PR-4.0-dev Unit/System Tests labels Jan 17, 2018

C-Lodder approved these changes Jan 17, 2018

View reviewed changes

drone

97c99cb

Merge branch '4.0-dev' into print_email

a1a3188

Quy reviewed Jan 19, 2018

View reviewed changes

C-Lodder mentioned this pull request Jan 19, 2018

[4.0] Email to friend broken #19221

Closed

Quy reviewed Feb 13, 2018

View reviewed changes

brianteeman added 2 commits February 14, 2018 14:10

tidyup

dd15d9e

Merge branch '4.0-dev' into print_email

64cd3ad

brianteeman closed this Apr 3, 2018

rdeutz reopened this Apr 3, 2018

joomla-cms-bot changed the title ~~[4.0] Remove article print and email~~ [4.0] Remove article print and email Aug 18, 2018

brianteeman closed this Sep 25, 2018

brianteeman mentioned this pull request Feb 25, 2019

[4.0][a11y] 'Print' button changes from styled link to button #24006

Merged

brianteeman reopened this Feb 26, 2019

brianteeman closed this Feb 26, 2019

infograf768 mentioned this pull request Jun 8, 2019

[4.0] Remove article print and email #24025

Merged

brianteeman deleted the print_email branch December 6, 2019 23:11

Uh oh!

[4.0] Remove article print and email #19393

[4.0] Remove article print and email #19393

Uh oh!

Conversation

brianteeman commented Jan 17, 2018

Uh oh!

C-Lodder commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdeutz commented Jan 17, 2018

Uh oh!

C-Lodder commented Jan 17, 2018

Uh oh!

rdeutz commented Jan 17, 2018

Uh oh!

ghost commented Jan 17, 2018

Uh oh!

brianteeman commented Jan 17, 2018

Uh oh!

rdeutz commented Jan 17, 2018

Uh oh!

C-Lodder commented Jan 17, 2018

Uh oh!

brianteeman commented Jan 17, 2018

Uh oh!

rdeutz commented Jan 17, 2018

Uh oh!

astridx commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Jan 19, 2018

Uh oh!

Quy Jan 19, 2018

Choose a reason for hiding this comment

Uh oh!

brianteeman Jan 19, 2018

Choose a reason for hiding this comment

Uh oh!

Quy Feb 13, 2018

Choose a reason for hiding this comment

Uh oh!

brianteeman Feb 13, 2018

Choose a reason for hiding this comment

Uh oh!

infograf768 commented Feb 15, 2018

Uh oh!

ciar4n commented Feb 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

C-Lodder commented Feb 15, 2018

Uh oh!

C-Lodder commented Feb 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Feb 15, 2018

Uh oh!

mbabker commented Feb 15, 2018

Uh oh!

infograf768 commented Feb 15, 2018

Uh oh!

mbabker commented Feb 15, 2018

Uh oh!

dgrammatiko commented Feb 15, 2018

Uh oh!

brianteeman commented Feb 15, 2018

Uh oh!

infograf768 commented Apr 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbabker commented Apr 4, 2018

Uh oh!

infograf768 commented Apr 5, 2018

Uh oh!

mbabker commented Apr 5, 2018

Uh oh!

brianteeman commented Jul 13, 2018

Uh oh!

infograf768 commented Jul 14, 2018

Uh oh!

C-Lodder commented Jan 17, 2018 •

edited

Loading

astridx commented Jan 17, 2018 •

edited

Loading

ciar4n commented Feb 15, 2018 •

edited

Loading

C-Lodder commented Feb 15, 2018 •

edited

Loading

infograf768 commented Apr 4, 2018 •

edited

Loading