-
Notifications
You must be signed in to change notification settings - Fork 145
Give docs a proper update #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
Coverage ? 75.82%
=========================================
Files ? 14
Lines ? 1212
Branches ? 0
=========================================
Hits ? 919
Misses ? 293
Partials ? 0
Continue to review full report at Codecov.
|
jasonrhansen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me! Other than the few typos I pointed out I have nothing to add.
|
@jasonrhansen great, thanks for the review! I'll leave this open for a bit longer in case @JordiChauzi also has a chance to take a look, otherwise I'll merge towards the end of today EST. |
|
For different structures implementing |
JordiChauzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is really clear and complete (minus the possible examples that we may add later).
Seems good to me.
|
I think it's useful to spell out the defaults in the docs since they're not otherwise visible anywhere beyond digging into the code. It's true that we'd have to make sure update the docs if the defaults change, but at the same time I think these defaults should also be relatively unlikely to change :) |
|
Thanks for the review from both of you! I'll merge once CI passes! |
|
@jasonrhansen I added some more docs following #60 in 3e706ea. Can you take a quick look? |
|
Thanks for adding docs for differentials! I made "Flame Graph" the default for the title in |
|
@jasonrhansen done in 924421b |
I've made a pass on pretty much all the docs, as well as the names of a few types, to try to clean up the externally-visible API. It'd be awesome if someone could give it all a read through and see that a) the structure of the API makes sense, b) I'm not saying anything totally false, and c) there aren't any gaping holes that we should fill immediately.
I have included any example code somewhat intentionally since I'm guessing the external APIs are likely to change a decent amount with #30.