[Urgent] fix generate model optional double type#221
Merged
CpdnCristiano merged 1 commit intojonataslaw:masterfrom Sep 8, 2023
Merged
[Urgent] fix generate model optional double type#221CpdnCristiano merged 1 commit intojonataslaw:masterfrom
CpdnCristiano merged 1 commit intojonataslaw:masterfrom
Conversation
b471cf0 to
30c3813
Compare
6e20ba8 to
5ea3fda
Compare
7b16fb2 to
471ec67
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is when the json value doesn't have decimal sometimes.
For Example normal value.
{ "some_value": 123.45 }And then it works with before.
=======================================================
But sometimes when value doesn't have decimal like this in same attribute.
{ "some_value": 123 }It will be seen as an
int, my solution should declare asnum?first. then usetoDouble()