[plugins] Change weather API to OpenWeatherMap#192
Merged
johnmaguire merged 2 commits intojohnmaguire:masterfrom Jun 12, 2021
obviyus:weather-api
Merged
[plugins] Change weather API to OpenWeatherMap#192johnmaguire merged 2 commits intojohnmaguire:masterfrom obviyus:weather-api
johnmaguire merged 2 commits intojohnmaguire:masterfrom
obviyus:weather-api
Conversation
lailoken503
approved these changes
Jun 11, 2021
lailoken503
left a comment
There was a problem hiding this comment.
Made a backup of the original plugin, and copied the update into a new plugin.py, looks like it works great, bonus that the .setw didn't need to be used again. Thanks!
Owner
|
Thanks for this! There was a hiccup in that OpenWeatherMap doesn't seem to return the same location for many old queries - especially around zip codes. I ended up implementing WeatherAPI.com as well. There's a toggle now, so either provider can be selected via configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191.
geopyto get a standard lat/lon format for all locations.