Skip to content

Add music icons next to YT music video titles#190

Merged
johnmaguire merged 1 commit intojohnmaguire:masterfrom
dkim286:youtube-plugin-music
Jun 8, 2021
Merged

Add music icons next to YT music video titles#190
johnmaguire merged 1 commit intojohnmaguire:masterfrom
dkim286:youtube-plugin-music

Conversation

@dkim286
Copy link
Copy Markdown
Contributor

@dkim286 dkim286 commented Jun 5, 2021

Resolves this issue: #179

@dkim286
Copy link
Copy Markdown
Contributor Author

dkim286 commented Jun 5, 2021

I forgot to add, the value (10) is based on the result of the query made to YouTube API on June 4th 2021:

>>> for kind in y.json()['items']:
...     print(kind['id'], kind['snippet']['title'])
... 
1 Film & Animation
2 Autos & Vehicles
10 Music
15 Pets & Animals
17 Sports
18 Short Movies
19 Travel & Events
20 Gaming
21 Videoblogging
22 People & Blogs
23 Comedy
24 Entertainment
25 News & Politics
26 Howto & Style
27 Education
28 Science & Technology
29 Nonprofits & Activism
30 Movies
31 Anime/Animation
32 Action/Adventure
33 Classics
34 Comedy
35 Documentary
36 Drama
37 Family
38 Foreign
39 Horror
40 Sci-Fi/Fantasy
41 Thriller
42 Shorts
43 Shows
44 Trailers
>>>

@johnmaguire
Copy link
Copy Markdown
Owner

@dkim286 This looks great! I'll test it out locally soon and then merge it in. Thank you for the PR!

@johnmaguire johnmaguire merged commit 5e2adcc into johnmaguire:master Jun 8, 2021
@johnmaguire
Copy link
Copy Markdown
Owner

Worked great, thanks again!

@johnmaguire
Copy link
Copy Markdown
Owner

Oh, by the way, it's totally optional, but feel free to submit another PR updating the CONTRIBUTORS file with your name!

@dkim286
Copy link
Copy Markdown
Contributor Author

dkim286 commented Jun 10, 2021

thank you. i''ll do so once i've cleared some coursework backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants