Added support for .cbr, .cbt and .cb7#56
Open
Protected wants to merge 2 commits intojohnfactotum:mainfrom
Open
Added support for .cbr, .cbt and .cb7#56Protected wants to merge 2 commits intojohnfactotum:mainfrom
Protected wants to merge 2 commits intojohnfactotum:mainfrom
Conversation
Owner
|
IIRC libarchive does not do random access. It's mainly for streaming, I think. Also it would be better if the files could be built from NPM, like the other vendored libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses nika-begiashvili/libarchivejs which makes uses of WASM and workers, and outwardly seems to support random access. However, while ZIP is also supported, I don't have time right now to run the performance tests to check whether this solution is a suitable replacement for the previously existing ZIP library, so I left that in.
I tested and confirmed support for the following formats: