Skip to content

Why not just use deep-translator? #15

@nidhaloff

Description

@nidhaloff

Hi, I stumbled across this library by chance and I can't help but notice that the code (or at least a good part of it) under wordhoard/utilities/deep_translator.py is clearly copy-pasted from the deep-translator library. Like even the name of the file is the name of the library. Most of the code is exactly the same as in deep-translator, even variable names. Why not just use the library? it is open source anyway

Like, I understand that you added some extra stuff to it, but it would have been cool to just use the library as it is (as a dependency) or for example to give credit in your README or docs.

I think as open source developers, it would be really great if we support each other and the bare minimum in this case would be just to mention or give credits to someone for their work, because most of the time it is taken for granted.

Congratulation on your library/work. Keep up the good work.
IMHO, It would be cool if you just use deep-translator as a third party lib because you will get the last updates, so more features, definitely bug fixes and most importantly support.

Metadata

Metadata

Assignees

Labels

discussiondiscussion about new feature or suggestions

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions