zoom: Improve keyboard shortcuts #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @MaeIsBad , would you mind resolving the conflict here? Happy to merge afterwards. |
I find this much more intuitive and it seems like this is how it's implemented in most other similar diagram viewers(eg. mermaid.live)
MaeIsBad
force-pushed
the
improve_panning_keybinds
branch
from
f134452 to
f1264d7
Compare
|
Done, thanks for the quick turnaround :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the keyboard shortcuts behavior a tiny bit, allowing users to pan with middle mouse button without holding ctrl, and allowing them to keep panning the diagram after letting go of ctrl.
This is closer to the behavior of mermaid.live and other diagram viewers.