Bumped dependencies to support connectivity_plus 6.x#65
Merged
jogboms merged 2 commits intojogboms:masterfrom Jul 11, 2024
Merged
Bumped dependencies to support connectivity_plus 6.x#65jogboms merged 2 commits intojogboms:masterfrom
jogboms merged 2 commits intojogboms:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 49 49
=========================================
Hits 49 49 ☔ View full report in Codecov by Sentry. |
jogboms
reviewed
Jul 11, 2024
Owner
jogboms
left a comment
jogboms
left a comment
There was a problem hiding this comment.
This is great work, there's one more edit to make to the README's example
Contributor
Author
|
You're right! It should be fine now |
jogboms
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @jogboms , I took the chance to bump some dependencies to support newer versions like connectivity_plus and network_info_plus. I decided to bump to a major since connectivity_plus decided to change all their signatures 😄
I hope this helps. Feel free to ask for changes, I'll be happy to help.
Closes #64