Closed
Conversation
Rename address to hostToCheck and add checkHost option
Owner
|
@badlee this is a good addition. I would do a review ASAP. |
Owner
|
@badlee this took an awfully long time than expected. I have been swamped with normal work. Could you maybe update the tests for this? |
Author
|
@jogboms yes I'll do it. |
jogboms
reviewed
Apr 15, 2019
| ) : _connectivityStream; | ||
| _connectivityStream = _connectivityStream.transform( | ||
| debounce(widget.debounceDuration), | ||
| ); |
Owner
There was a problem hiding this comment.
How about..
if (widget.checkHost) {
_connectivityStream = _connectivityStream.transform(
checkIfHostIsAvailble(widget.hostToCheck),
);
}
_connectivityStream = _connectivityStream.transform(
debounce(widget.debounceDuration),
);
Owner
|
@badlee do you wish to continue on this, or i should i take it over? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OfflineBuilder can now check if internet is avaible by lookup google (or other host), if is not avaible the connection is sate to ConnectivityResult.none
I have add two properties to OfflineBuilder
Usage