Skip to content

[erb] remove .strip from code in :code section #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreiDreyer merged 3 commits into from
May 12, 2025
Merged

[erb] remove .strip from code in :code section #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ba9d3b
Trying to fix do blcoks
AndreiDreyer May 12, 2025
a3b6ab0
stop stripping code in :code section
AndreiDreyer May 12, 2025
e239aed
Merge branch 'main' into andrei/ruby-erb-support-fix-do
AndreiDreyer May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/ruby_ast_gen/erb_to_ruby_transformer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,13 @@ def visit(node)
@output << "#{buffer_to_use} << \"#{@static_buff.join('\n').gsub(/(?<!\\)"/, '')}\""
@static_buff = [] # clear static buffer
end
code = node[1].to_s.strip

stripped_code = node[1].to_s.strip
code = node[1].to_s
# Using this to determine if we should throw a StandardError for "invalid" ERB
if is_control_struct_start(code)
if is_control_struct_start(stripped_code)
@in_control_block = true
@output << code
@output << stripped_code
elsif code.start_with?("end")
if @in_do_block
@in_do_block = false
Expand Down
Loading