Skip to content

Conversation

@jlowin
Copy link
Owner

@jlowin jlowin commented Oct 14, 2025

Windows subprocess calls were using shell=True unnecessarily, which invokes cmd.exe as an intermediary and increases attack surface. While these calls are user-initiated and don't accept untrusted input, removing shell=True follows security best practices and eliminates potential future concerns.

The change replaces shell=True with explicit command construction where needed. This should have no impact on functionalit.

@marvin-context-protocol marvin-context-protocol bot added enhancement Improvement to existing functionality. For issues and smaller PR improvements. cli Related to FastMCP CLI commands (run, dev, install) or CLI functionality. labels Oct 14, 2025
@jlowin jlowin added bug Something isn't working. Reports of errors, unexpected behavior, or broken functionality. and removed enhancement Improvement to existing functionality. For issues and smaller PR improvements. labels Oct 14, 2025
@jlowin jlowin merged commit 5f8461b into main Oct 14, 2025
10 checks passed
@jlowin jlowin deleted the windows-shell branch October 14, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. Reports of errors, unexpected behavior, or broken functionality. cli Related to FastMCP CLI commands (run, dev, install) or CLI functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants