Escape all HTML to prevent XSS attack #2090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-context-protocol
bot
added
bug
jlowin
removed
the
auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAuth callback page embedded user-controlled query parameters directly into HTML without escaping, creating a reflected XSS vulnerability. An attacker could inject malicious JavaScript through parameters like
errororerror_description, which would execute in the victim's browser when the callback page rendered.This adds
html.escape()to all UI utility functions that render user content, ensuring XSS payloads are properly escaped before rendering. The fix applies escaping at the start of each function for clarity and maintainability.