Replace subprocess tests with in-process async servers #2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-context-protocol
bot
added
enhancement
Collaborator
|
Do we actually need to use anyio for this? When I did this in my projects, removing asyncio_default_fixture_loop_scope = "session" and asyncio_default_test_loop_scope = "session" was enough to be able to create, yield, and connect to running servers. Anyway, looks great |
Owner
Author
|
@strawgate I'll investigate, would love if that was the case |
Owner
Author
|
I learned Anthropic uses anyio extensively internally so got remotivated to look at this again |
- Convert run_server_async from anyio task group pattern to asyncio.create_task with async context manager - Remove task_group fixture from conftest - Update all test fixtures to use async with run_server_async pattern - Remove TaskGroup imports from all test files - Tests now work with pytest-asyncio instead of pytest-anyio
jlowin
changed the title
Owner
Author
|
@strawgate you were right, got everything working with asyncio, no need for anyio in tests! I will however take a look at replacing some asyncio primitives with anyio ones in the library in the future just for compatibility, but this feels great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces subprocess-based server tests with in-process async servers using asyncio context managers. This dramatically improves test performance and provides proper tracebacks when errors occur, making debugging significantly easier.
Migrates 19 fixtures across 10 test files from
run_server_in_process()to the simplerrun_server_async()pattern, eliminating the overhead of spawning separate processes while maintaining all existing functionality.