Refactor OAuth 2.1 error handling with TokenHandler subclass #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-context-protocol
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the OAuth 2.1 error handling approach from #1923 by using a cleaner
TokenHandlersubclass instead of wrapping and parsing responses.Per OAuth 2.1 Section 5.3 and MCP spec requirements, invalid clients must receive HTTP 401.
Note: This replaces the implementation from #1923. The original approach was completely valid and we appreciate the contribution! This refactor just makes the code a bit more maintainable by working at the model layer rather than parsing serialized responses. I think the only operational difference here is maintaining the SDK's use of CORS middleware - I am not sure to what degree this has impact.