chore: Update SDK documentation #1645
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-context-protocol
bot
force-pushed
the
marvin/update-sdk-docs
branch
from
3cc6591 to
695739d
Compare
marvin-context-protocol
bot
force-pushed
the
marvin/update-sdk-docs
branch
from
695739d to
c41e44b
Compare
marvin-context-protocol
bot
force-pushed
the
marvin/update-sdk-docs
branch
from
c41e44b to
a595bdf
Compare
marvin-context-protocol
bot
force-pushed
the
marvin/update-sdk-docs
branch
2 times, most recently
from
e15c57e to
2720e80
Compare
marvin-context-protocol
bot
force-pushed
the
marvin/update-sdk-docs
branch
2 times, most recently
from
6a29942 to
6d46192
Compare
chrisguidry
added a commit
that referenced
this pull request
Nov 20, 2025
Analyzed the official SEP-1686 specification against both the MCP SDK's draft implementation (PR #1645) and FastMCP's current shims. Made corrections to match the spec exactly. **Key changes:** 1. **Removed `error` field** - Spec only defines `statusMessage` for error details. Changed all handlers to use `statusMessage` instead of separate `error` field. 2. **Removed non-spec status values** - Spec defines exactly 5 statuses: `working`, `input_required`, `completed`, `failed`, `cancelled`. Removed FastMCP's `"submitted"` and `"unknown"` extensions. 3. **Non-existent tasks raise errors** - Aligned with SDK behavior: `tasks/get` for non-existent/deleted tasks raises `ValueError` (JSON-RPC error) instead of returning synthetic `status="unknown"`. 4. **Test updates** - Fixed 12+ tests expecting removed statuses. Changed assertions to expect JSON-RPC errors for not-found scenarios. **What stayed the same:** - Client already sends both `task=` (spec-compliant) and `_meta=` (SDK compatibility) - Server monkeypatches work correctly for request params - `createdAt` as ISO 8601 string matches spec (SDK uses datetime but serializes same) - `ttl` field naming confirmed correct in both spec and SDK All 3270 tests passing. FastMCP is now fully aligned with SEP-1686 final specification. Related: modelcontextprotocol/python-sdk#1645 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the auto-generated SDK documentation to reflect the latest source code changes.
📚 Documentation is automatically generated from the source code docstrings and type annotations.
Note: This PR is fully automated and will update itself with any subsequent changes to the SDK, or close automatically if the documentation becomes up-to-date through other means. Feel free to leave it open until you're ready to merge.
🤖 Generated by Marvin