Skip to content

We are dumping our ResultSets and not the underlied database. Use schema->clone instead of _schema_from_database #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KES777 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

We are dumping our ResultSets and not the underlied database. Use schema->clone instead of _schema_from_database #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcfeed3
We dumping our result sets not underlied database
KES777 Jul 18, 2018
fd8aa3f
Improved test: This is not required that ResultSet class name should …
Apr 6, 2025
6bc46ec
Fixing another place where 'schame' should be used instead of real da…
Apr 6, 2025
cc3288e
Set quote_char for sql_maker by default, as it were requested at #66
Sep 6, 2025
adb244e
Update CONTRIBUTORS
Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.mkdn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,7 @@ missed you.
https://github.com/manwar
https://github.com/upasana-me
https://github.com/rabbiveesh
https://github.com/KES777

# SEE ALSO

Expand Down
12 changes: 9 additions & 3 deletions lib/DBIx/Class/Migration.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,13 @@ has schema => (is=>'lazy', predicate=>'has_schema');

sub _build_schema {
my ($self) = @_;
$self->schema_class->connect(@{$self->schema_args});
my $schema = $self->schema_class->connect(@{$self->schema_args});
my $storage = $schema->storage;
if( !$storage->sql_maker->quote_char ) {
$storage->sql_maker->quote_char( $storage->sql_quote_char );
}

return $schema;
}

has target_dir_builder_class => (
Expand Down Expand Up @@ -426,7 +432,7 @@ sub dump_named_sets {
(my $self = shift)->dbic_dh->version_storage_is_installed
|| print "Target DB is not versioned. Dump may not be reliable.\n";

my $schema = $self->_schema_from_database;
my $schema = $self->schema->clone;

$self->build_dbic_fixtures->dump_config_sets({
schema => $schema,
Expand All @@ -446,7 +452,7 @@ sub dump_all_sets {
(my $self = shift)->dbic_dh->version_storage_is_installed
|| print "Target DB is not versioned. Dump may not be reliable.\n";

my $schema = $self->_schema_from_database;
my $schema = $self->schema->clone;

$self->build_dbic_fixtures->dump_all_config_sets({
schema => $schema,
Expand Down
2 changes: 1 addition & 1 deletion t/lib/Local/Schema/Result/ArtistCd.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package Local::Schema::Result::ArtistCd;
use base qw/DBIx::Class::Core/;

__PACKAGE__->table('artist_cd');
__PACKAGE__->table('artist_cd_not_match');
__PACKAGE__->add_columns(
artist_fk => {
data_type => 'integer',
Expand Down
2 changes: 1 addition & 1 deletion t/lib/Local/v2/Schema/Result/ArtistCd.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package Local::v2::Schema::Result::ArtistCd;
use base qw/DBIx::Class::Core/;

__PACKAGE__->table('artist_cd');
__PACKAGE__->table('artist_cd_not_match');
__PACKAGE__->add_columns(
artist_fk => {
data_type => 'integer',
Expand Down