Fix: rotate resize param on multiples of 90 #1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 PR was released in |
This was referenced May 24, 2024
This was referenced May 25, 2024
This was referenced May 29, 2024
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
Before #1209 specifying resize=false with
rotate()would never resize the image, however the new matrix rotation algo will always resize the image regardless of this parameter. This PR introcudes some more checks to see if matrix rotation can be used and otherwise falls back to usingadvancedRotateWhat else might be affected
Shouldn't affect anything, fixes incorrect behavior.
Tasks
jimp.d.ts