Fixes bug where Slate crashes if window hints is triggered in certain contexts (Emacs.app or Calendar.app visible) #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…local variable causes Slate to crash if window hints is triggered in certain contexts (Emacs.app visible or Calendar.app visible).
|
Bump @jigish |
|
Thanks! I've forked Slate for continuing maintenance and integrated this change into mattr-/slate@05f6f3a |
|
Closing Since this project is no longer in active development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This bug is not reproducible if .slate has
config windowHintsIgnoreHiddenWindows falseBug previously raised in this issue:
#303
Patch is simply a one line change to initialize local variable in AccessibilityWrapper.m:getTitle:window which subsequently fixes the bug.