Add UTF-8 byte order mark to CSV and TSV downloads so that files will be parsed by Excel correctly.#1043
Open
craiga wants to merge 1 commit into
Open
Add UTF-8 byte order mark to CSV and TSV downloads so that files will be parsed by Excel correctly.#1043craiga wants to merge 1 commit into
craiga wants to merge 1 commit into
Conversation
… be parsed by Excel correctly.
craiga
force-pushed
the
byte-order-mark-for-csv
branch
from
4370842 to
efb3f31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix #1041.
Note that this requires some pretty liberal conversion from
utf8toutf-8-sigto consume these byte order markers.While this would make life easier for Excel users, it might frustrate people using other software, especially anyone using a CSV in their own code (example).
Given all of this, I'm not 100% convinced what I've done here is the right approach. Perhaps adding another format for CSV with a BOM would be better ("csv-excel"? "csv-with-bom"?), but explaining the differences between those formats wouldn't be easy.