[201911] Backport: Add the pre_reboot_hook script execution, add the watchdog arm before the reboot#5
Closed
[201911] Backport: Add the pre_reboot_hook script execution, add the watchdog arm before the reboot#5
Conversation
jianyuewu
force-pushed
the
backport-reboot-patch
branch
from
87666f7 to
cc0e7ec
Compare
Owner
Author
|
Master branch test passed, 201911 branch test ongoing. |
jianyuewu
changed the title
jianyuewu
changed the title
What I did Add the pre_reboot_hook script execution, add the watchdog arm before the reboot, in order to support the graceful reboot instead of the sysfs power cycle, to avoid filesystem corruption. How I did it Modify the scripts/reboot How to verify it Start watching logs by using show log -f and journalctl -p debug -f Execute the reboot command from the switch CLI Check in logs that all systemd services terminated correctly Previous command output (if the output of a command-line utility has changed) New command output (if the output of a command-line utility has changed) Signed-off-by: Jianyue Wu <[email protected]>
- What I did Add back the support to call reboot -f The support for this option was accidentally removed as part of this PR sonic-net#3203 The same PR for 202311 doesn't have this mistake - sonic-net#3204 - How I did it - How to verify it Call reboot -f
jianyuewu
force-pushed
the
backport-reboot-patch
branch
from
cc0e7ec to
358a99a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport commits sonic-net#3492 and sonic-net#3203.
What I did
Add back the support to call reboot -f.
The support for this option was accidentally removed as part of this PR sonic-net#3203.
The same PR for 202311 doesn't have this mistake - sonic-net#3204.
Add the pre_reboot_hook script execution, add the watchdog arm before the reboot, in order to support the graceful reboot instead of the sysfs power cycle, to avoid filesystem corruption.
How I did it
Add back option -f for reboot script.
Modify the scripts/reboot.
How to verify it
Call reboot -f.
Start watching logs by using show log -f and journalctl -p debug -f.
Execute the reboot command from the switch CLI.
Check in logs that all systemd services terminated correctly.