Fix device appearing offline#24
Merged
jfarseneau merged 1 commit intojfarseneau:masterfrom Jun 16, 2018
Merged
Conversation
… HDHomerun. Add ENV to set device uuid Update device.js Try with dashes Update router.js Seeing if adding .xml works Update ssdp.js Try adding uuid to the server Add UID handling, BaseURL and rename the device so it's prefixed with HDHomerun. Add ENV to set device uuid
behinddesign
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes seem to keep the device marked as online once it's added and in most cases allows for the device to be automatically found.
It does seem however that Plex does act strangely sometimes, but once a device has been added, it appears to remain online.
It is recommended to delete the existing device so the new UUID is marked with this device, along with the SSDP packets being marked with the correct UUID fixes most problems. Other adjustments have been inspired by https://github.com/tombowditch/telly , such as the name of the device and baseurl in the device.xml.
Restarting Plex once a device has been added seems to be required
ControlURL and EventSubURL adjustments have an unknown result, it appears plex never calls them anyway. I have left them in there but they could probably be reverted. It however didn't make sense to revert them as the endpoint didn't match the URL