Fixes #8014 - Review HttpRequest URI construction. #8015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now always adding a "/" before the path, if not already present. Disabled flakey HTTP/3 test. Signed-off-by: Simone Bordet <[email protected]>
Contributor
|
@simone, i think we should also fix the asString method in HttpURI. I know it's not used, but it makes the same mistake with non root paths. |
Fixes after review in HttpURI. Signed-off-by: Simone Bordet <[email protected]>
joakime
previously approved these changes
May 23, 2022
Contributor
joakime
left a comment
joakime
left a comment
There was a problem hiding this comment.
I like the IllegalArgumentExceptions on this
More fixes after review in HttpURI. Signed-off-by: Simone Bordet <[email protected]>
joakime
previously approved these changes
May 23, 2022
Contributor
joakime
left a comment
joakime
left a comment
There was a problem hiding this comment.
The OPTIONS path of * makes this interesting for sure.
isPathValidForAuthority(String) method makes this much easier to understand now too.
Contributor
|
Note, I'm working on fixing the test failure on this one. |
Contributor
joakime
approved these changes
May 24, 2022
Contributor
joakime
left a comment
joakime
left a comment
There was a problem hiding this comment.
Seems like a reasonable change.
Lets see what the CI build/test shows.
Contributor
|
The CI failure was an unrelated problem with a repository. Retrying... |
Contributor
|
Still having CI issues... which I think are unrelated. If I get a clean build (again) locally, I will merge. |
HyukjinKwon
pushed a commit
to apache/spark
that referenced
this pull request
Jul 9, 2022
…4.48.v20220622 ### What changes were proposed in this pull request? Upgrade `jetty-http` from 9.4.46.v20220331 to 9.4.48.v20220622 ### Why are the changes needed? [Release note](https://github.com/eclipse/jetty.project/releases) [CVE-2022-2047](https://nvd.nist.gov/vuln/detail/CVE-2022-2047) Info from Github dependabot ### Invalid URI parsing may produce invalid HttpURI.authority ### Description URI use within Jetty's `HttpURI` class can parse invalid URIs such as `http://localhost;/path` as having an authority with a host of `localhost;`. A URIs of the type `http://localhost;/path` should be interpreted to be either invalid or as `localhost;` to be the userinfo and no host. However, `HttpURI.host` returns `localhost;` which is definitely wrong. ### Impact This can lead to errors with Jetty's `HttpClient`, and Jetty's `ProxyServlet` / `AsyncProxyServlet` / `AsyncMiddleManServlet` wrongly interpreting an authority with no host as one with a host. ### Patches Patched in PR jetty/jetty.project#8146 for Jetty version 9.4.47. Patched in PR jetty/jetty.project#8015 for Jetty versions 10.0.10, and 11.0.10 ### Workarounds None. ### For more information If you have any questions or comments about this advisory: Email us at [securitywebtide.com](mailto:securitywebtide.com)." ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA Closes #37142 from bjornjorgensen/jetty-http-9.4.48.v20220622. Lead-authored-by: Bjørn Jørgensen <[email protected]> Co-authored-by: Bjorn Jorgensen <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now always adding a "/" before the path, if not already present.
Disabled flakey HTTP/3 test.
Signed-off-by: Simone Bordet [email protected]