Skip to content

Conversation

@Nevexo
Copy link
Contributor

@Nevexo Nevexo commented Jan 6, 2025

This pull request fixes #33 by introducing a new config entry EdidString and saves the EDID string to it when it's modified in the frontend.

This PR also introduces a method to restore the EDID on reboot/app restart by sending the EdidString back to jetkvm_native when it connects to the control socket.

This commit adds the config entry "EdidString" and saves the EDID string
when it's modified via the RPC.

The EDID is restored when the jetkvm_native control socket connects
(usually at boot)

Signed-off-by: Cameron Fleming <[email protected]>
Nevexo added a commit to Nevexo/jetkvm-kvm that referenced this pull request Jan 6, 2025
Signed-off-by: Cameron Fleming <[email protected]>
@vwal
Copy link

vwal commented Feb 1, 2025

Thanks for this @Nevexo!

Please merge this for the next firmware release.. it's annoying to have to re-select the functional EDID every time JetKVM restarts.

@Nevexo
Copy link
Contributor Author

Nevexo commented Feb 1, 2025

Thanks for this @Nevexo!

Please merge this for the next firmware release.. it's annoying to have to re-select the functional EDID every time JetKVM restarts.

I don't get to decide what goes into the next firmware release, the team may want to implant this differently.

The feature is, however, available in my tree: https://github.com/nevexo/jetkvm-kvm from next-5 onwards.

@vwal
Copy link

vwal commented Feb 1, 2025

Yeah, I figured you wouldn't be able to decide on approving the PR, but couldn't figure out who's the owner of [this] kvm project to tag.

Meanwhile, I'll take a look at your tree.

@Nevexo
Copy link
Contributor Author

Nevexo commented Feb 1, 2025

Yeah, I figured you wouldn't be able to decide on approving the PR, but couldn't figure out who's the owner of [this] kvm project to tag.

Meanwhile, I'll take a look at your tree.

FWIW, @adamshiervani and @chemhack are the designers and owners of JetKVM, and thus, are the ones that will decide on the PRs when they're less busy shipping units.

Nevexo added a commit to Nevexo/jetkvm-kvm that referenced this pull request Feb 11, 2025
Signed-off-by: Cameron Fleming <[email protected]>
Nevexo added a commit to Nevexo/jetkvm-kvm that referenced this pull request Feb 11, 2025
Signed-off-by: Cameron Fleming <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

@chemhack chemhack merged commit 0b5033f into jetkvm:dev Feb 13, 2025
1 check passed
@Nevexo Nevexo deleted the nevexo/save-edid branch February 13, 2025 13:42
Nevexo added a commit to Nevexo/jetkvm-kvm that referenced this pull request Feb 20, 2025
Signed-off-by: Cameron Fleming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setEDID() RPC does not save to the config

4 participants