-
Notifications
You must be signed in to change notification settings - Fork 260
feat: restore EDID on reboot #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds the config entry "EdidString" and saves the EDID string when it's modified via the RPC. The EDID is restored when the jetkvm_native control socket connects (usually at boot) Signed-off-by: Cameron Fleming <[email protected]>
Signed-off-by: Cameron Fleming <[email protected]>
|
Thanks for this @Nevexo! Please merge this for the next firmware release.. it's annoying to have to re-select the functional EDID every time JetKVM restarts. |
I don't get to decide what goes into the next firmware release, the team may want to implant this differently. The feature is, however, available in my tree: https://github.com/nevexo/jetkvm-kvm from next-5 onwards. |
|
Yeah, I figured you wouldn't be able to decide on approving the PR, but couldn't figure out who's the owner of [this] kvm project to tag. Meanwhile, I'll take a look at your tree. |
FWIW, @adamshiervani and @chemhack are the designers and owners of JetKVM, and thus, are the ones that will decide on the PRs when they're less busy shipping units. |
Signed-off-by: Cameron Fleming <[email protected]>
Signed-off-by: Cameron Fleming <[email protected]>
Signed-off-by: Cameron Fleming <[email protected]>
This pull request fixes #33 by introducing a new config entry
EdidStringand saves the EDID string to it when it's modified in the frontend.This PR also introduces a method to restore the EDID on reboot/app restart by sending the
EdidStringback to jetkvm_native when it connects to the control socket.