fix(cloud): only start WS Client if config.CloudToken is set #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevexo
added a commit
to Nevexo/jetkvm-kvm
that referenced
this pull request
Jan 5, 2025
tutman96
approved these changes
Jan 6, 2025
This was referenced Jan 28, 2025
Closed
Nevexo
added a commit
to Nevexo/jetkvm-kvm
that referenced
this pull request
Feb 11, 2025
Nevexo
added a commit
to Nevexo/jetkvm-kvm
that referenced
this pull request
Feb 11, 2025
Nevexo
added a commit
to Nevexo/jetkvm-kvm
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only starts the WebSocket client loop if a token was set in
config.CloudTokenat start time, it also starts the loop if the adoption process runs after the fact.This avoids your log being full of
Websocket client error: cloud token is not setwhile working on the application, and stops the loop pointlessly running.