Skip to content

Export ids as string, as it now overflow float#61

Merged
jetelain merged 1 commit intomainfrom
fix/arma-float-overflow
Nov 10, 2025
Merged

Export ids as string, as it now overflow float#61
jetelain merged 1 commit intomainfrom
fix/arma-float-overflow

Conversation

@jetelain
Copy link
Owner

No description provided.

@jetelain jetelain added the bug Something isn't working label Nov 10, 2025
@jetelain jetelain requested a review from Copilot November 10, 2025 20:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue where integer IDs are overflowing when serialized as floats by converting them to strings before serialization. The changes ensure that IDs are safely represented as strings in the exported data.

  • Converts integer IDs to strings using id.ToString() in three methods
  • Prevents potential data loss from integer-to-float conversions
  • Updates the data format for markers exported to SQF scripts
Comments suppressed due to low confidence (1)

Arma3TacMapLibrary/Maps/MapExporter.cs:152

  • The GetMissionLines method at line 152 still concatenates the integer id with a string, resulting in implicit ToString(). For consistency with the other methods changed in this PR, consider using explicit string conversion: id.ToString() + \".\" + index
                        id + "." + index,

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jetelain jetelain merged commit 2fbdd72 into main Nov 10, 2025
7 checks passed
@jetelain jetelain deleted the fix/arma-float-overflow branch November 10, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants