Export ids as string, as it now overflow float#61
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where integer IDs are overflowing when serialized as floats by converting them to strings before serialization. The changes ensure that IDs are safely represented as strings in the exported data.
- Converts integer IDs to strings using
id.ToString()in three methods - Prevents potential data loss from integer-to-float conversions
- Updates the data format for markers exported to SQF scripts
Comments suppressed due to low confidence (1)
Arma3TacMapLibrary/Maps/MapExporter.cs:152
- The GetMissionLines method at line 152 still concatenates the integer id with a string, resulting in implicit ToString(). For consistency with the other methods changed in this PR, consider using explicit string conversion:
id.ToString() + \".\" + index
id + "." + index,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.