Fixes the jest-haste-map mapper option#8299
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8299 +/- ##
======================================
Coverage 62.2% 62.2%
======================================
Files 266 266
Lines 10673 10673
Branches 2595 2595
======================================
Hits 6639 6639
Misses 3445 3445
Partials 589 589
Continue to review full report at Codecov.
|
scotthovestadt
approved these changes
Apr 10, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I forgot in my previous PR to forward the
mapperoption from theJestHasteMapoptions to the crawler option. It went unnoticed because the tests directly instantiate the crawler and because in Metro this logic wasn't necessary because the PnP resolution bypassed the Haste map.I noticed the problem by removing this bypass, which highlighted that the mapper never got called 😞
Test plan
Modified my Jest copy locally, checked that the mapper was called as it should be.